Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media & Text block: The link option does not work when the featured image is used #60497

Closed
carolinan opened this issue Apr 5, 2024 · 1 comment · Fixed by #60510
Closed

Media & Text block: The link option does not work when the featured image is used #60497

carolinan opened this issue Apr 5, 2024 · 1 comment · Fixed by #60510
Assignees
@carolinan
Labels
[Block] Media & Text Affects the Media & Text Block Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

carolinan commented Apr 5, 2024 •
edited
Loading

Description

When the Media & Text block uses the featured image, and a link is added using the block toolbar option, the link does not work because it does not wrap around the image.

It is not added to the block in index.php.

Step-by-step reproduction instructions

Activate Gutenberg
Create a new post and add a featured image.
Add a Media & Text block and select the option "Use featured image".
In the block toolbar, select the link option and add a link.
Save and view the front.
Confirm that the image is not linked.

Screenshots, screen recording, code snippet

No response

Environment info

Gutenberg 18.0 or newer, or Gutenberg trunk.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@carolinan carolinan added [Type] Bug An existing feature does not function as intended [Block] Media & Text Affects the Media & Text Block labels Apr 5, 2024
@carolinan carolinan self-assigned this Apr 5, 2024
@carolinan carolinan mentioned this issue Apr 5, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 5, 2024
@carolinan carolinan moved this to 🗣️ In Discussion / Needs Decision in WordPress 6.6 Editor Tasks May 20, 2024
@carolinan carolinan added the Needs Dev Ready for, and needs developer efforts label May 20, 2024
@fabiankaegy
Copy link
Member

This has also been brought up in the Core Editor channel in slack: https://wordpress.slack.com/archives/C02QB2JS7/p1716196185562119.

TLDR: We need help wit engineering

@fabiankaegy fabiankaegy moved this from 🗣️ In Discussion / Needs Decision to 📥 Todo in WordPress 6.6 Editor Tasks May 22, 2024
@ramonjd ramonjd mentioned this issue May 29, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.6 Editor Tasks May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
[Block] Media & Text Affects the Media & Text Block Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.6 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Media & Text block: Remove the link option when the featured image is used WordPress/gutenberg
2 participants
@carolinan @fabiankaegy