Pattern: unable to see white text when editing a pattern at the source

[gabbsmo]

Description

Since upgrading WP from 6.4 to 6.5.2 I lost the ability to edit synced patterns inline on a post where it is used. Instead I have the option to "Edit Original" which will open a new editor.

This is particularily troublesome if the pattern is using white text, that is designed for use on a dark background, i.e. a group block. In this case all text is invisible on the white background of the editor.

Step-by-step reproduction instructions

1. Create group block with dark background
2. Add some text with white font color
3. Create a synced pattern from the text
4. Click edit original

Environment info

WordPress 5.6.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[ktmn]

lost the ability to edit synced patterns inline on a post where it is used

I agree, this change was a regression in my opinion.

I tracked down where it changed and appears to be here: #57036

As part of the work on allowing partial editing of synced patterns we want to disable full editing of the synced pattern entities within the block editor.

---

Needs Design Feedback

Gutenberg = it's like a Word document, you click on the text and you can change it. Simple! Now when you click on a pattern nothing happens. The text is not editable. That's the end of the road for most people. Roll it back.

If this is needed for "partially synced patterns" then do it for "partially synced patterns" not for "synced patterns".

[annezazu]

Thanks for opening this issue. To build on what was shared above, this change was done to accommodate an upcoming feature that allows you to have a synced pattern with the option to allow for specific parts of it to be overridden within individual patterns. This means you could have part of a design and text set across all synced patterns along with some customization to make specific instances of the same pattern your own. As a result, the new experience was introduced. It's a trade off for sure but it won't be rolled back as is.

[annezazu]

With that said, I've updated the name and labeling of this issue a bit to see what we can do to address the issue around the white text and being unable to see the background!

[gabbsmo]

My spontaneous suggestion is to introduce a toggleable dark mode to Gutenberg/WP Dashboard.

[richtabor]

This is what I'm getting. Do you mind sharing a screen recording (and/or do you notice a variable)?

CleanShot.2024-04-23.at.17.06.42.mp4

[gabbsmo]

It looks like you include the background group in your pattern so that will naturally work. Try only selecting the paragraphs of text inside the group and create the pattern from that. Then you should get what I described in the OP.

I don't have a recording right now but can make it later if you need it.

[talldan]

If this is needed for "partially synced patterns" then do it for "partially synced patterns" not for "synced patterns".

@ktmn The challenge here is that it will be possible to use both partially synced patterns and synced patterns in the same post, so having inconsistent editing of those patterns would be a confusing experience.

The change did also fix this bug - Editing a Synced Pattern that you don't have permission to edit is a poor user experience.