-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Bindings: Notify on save when users edit the value of a connected custom field instead of the post content #61405
Comments
It should be more granular and refer to the custom fields, right? I think it should even get more granular so that you can see all of the individual custom fields have been updated. I believe that's what I'd personally prefer to see, though I understand that would probably vary depending on how technical the user is. |
@jasmussen We have a very rough, preliminary implementation going here in case you'd like to take a look. |
Just connecting dots with a comment here, on a potential path forward: #61560 (comment) |
Initial integration landed on Friday with #61811. This is how it looks like in the post editor when other posts get modified, for example when using Query Loop block with Block Bindings defined in the post template: |
New issue opened here: #62938 |
This is part of a broader effort to improve the block bindings UI.
What?
When saving a post, specify if it updates the post content or the value of the custom fields.
As part of the block bindings project, it is expected to allow the users to edit the value of the source connected to the block directly through the rich text. It was showcased in this Gutenberg Hallway Hangout, and there is an ongoing PR for post meta here.
This means that if a paragraph's content is connected to a custom field, users will edit the value of the custom field instead of the post content. It'd be great to clarify that during the saving in the same way we do with other entities.
At first, I thought it was gonna work out of the box because it is actually using the proper
editEntityRecord
function: link. However, in the end we are just editing the post entity, and it doesn't differentiate between editing the content or other parts like meta fields.Would it make sense to specify which parts of the entity are being updated and, in case the meta fields are part of that, trigger the same "warning" as when we edit an external entity like in the previous example? Something like this but properly designed:
The text was updated successfully, but these errors were encountered: