Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List view: empty settings menus for non-editable items instead of a lock icon #62352

Closed
ramonjd opened this issue Jun 6, 2024 · 0 comments · Fixed by #62354
Closed

List view: empty settings menus for non-editable items instead of a lock icon #62352

ramonjd opened this issue Jun 6, 2024 · 0 comments · Fixed by #62354
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@ramonjd
Copy link
Member

ramonjd commented Jun 6, 2024

Description

Block settings and other actions can be accessed via an ellipsis menu for items in the list view.

When a block is locked there are no actions/settings, however an empty drop down menu still appears (in BlockSettingsMenu).

Previously there was a lock icon. See:

const shouldShowLockIcon = isLocked && ! isContentOnly;

Step-by-step reproduction instructions

  1. Go to any page or post in the post editor
  2. In the Post/Page settings on the right, activate "Show template"
  3. Open the list view and click on the ellipsis menu of non-editable items, e.g., template parts, content or title blocks
  4. Observe that the menu is empty

Screenshots, screen recording, code snippet

2024-06-06.14.22.03.mp4
Screenshot 2024-06-06 at 2 23 16 PM

Environment info

Latest Gutenberg trunk on WP 6.6-beta1-58338

Also on 6.6-beta1-58338 with Gutenberg deactivated

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ramonjd ramonjd added [Type] Bug An existing feature does not function as intended [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Jun 6, 2024
@ramonjd ramonjd added [Type] Regression Related to a regression in the latest release and removed [Type] Bug An existing feature does not function as intended labels Jun 6, 2024
@ramonjd ramonjd changed the title List view: hide empty settings menus for non-editable items List view: empty settings menus for non-editable items instead of a lock icon Jun 6, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant