Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site editor: WP logo focus style regression #62672

Closed
afercia opened this issue Jun 19, 2024 · 1 comment · Fixed by #62675
Closed

Site editor: WP logo focus style regression #62672

afercia opened this issue Jun 19, 2024 · 1 comment · Fixed by #62675
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Jun 19, 2024

Description

The focus style of the WP logo in the Site editor is now barely visible and not standard.

This is the focus style on WordPress 6.5:

wp 6 5

This is the focus style on Gutenberg trunk:

trunk

The WP logo uses a custom implementation of the focus style. I think the regression comes from the fact the transform scale CSS is now applied to the link element itself while previously it was applied to the inner div element.

Step-by-step reproduction instructions

  • Go to the Site editor.
  • Tab to the WP logo.
  • Observe the focus style is barely visible and not standard.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 19, 2024
@up1512001
Copy link
Member

@afercia moved the focus from before to the a tag itself in this PR.
#62675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants