Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor toolbar toggle buttons accessibility #628

Closed
afercia opened this issue May 3, 2017 · 1 comment
Closed

Improve editor toolbar toggle buttons accessibility #628

afercia opened this issue May 3, 2017 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented May 3, 2017

As noted in #558, the buttons in the inline toolbars behave as a toggle. Not just the alignment ones, also bold, italic, etc. and all the ones that need to be toggled to change a state.

Visually, their state is communicated with a color inversion. Semantically, there's nothing to communicate their state. This kind of toggle buttons need an aria-pressed attribute with true/false value. This way, assistive technologies can communicate the buttons state.

As they work now:

bold

Compare for example to what TinyMCE does:

screen shot 2017-05-03 at 17 01 39

TinyMCE uses divs for the buttons and then "resets" the real buttons semantic with role=ppresentation, but that's not the point, the necessary semantics is all there on the divs.

The editor toolbar would need further a11y improvements that should go in separate issues:

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 3, 2017
@afercia
Copy link
Contributor Author

afercia commented May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

1 participant