Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The BlockBreadcrumb shouldn't be a NavigableToolbar #6337

Closed
afercia opened this issue Apr 21, 2018 · 0 comments
Closed

The BlockBreadcrumb shouldn't be a NavigableToolbar #6337

afercia opened this issue Apr 21, 2018 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Apr 21, 2018

The BlockBreadcrumb component added in #5658 is wrapped in a NavigableToolbar component.

Seems to me this is not appropriate because:

  • NavigableToolbar adds arrows navigation via NavigableMenu
  • it also adds a role="toolbar" which is not appropriate in this case.

Maybe I'm missing something but since BlockBreadcrumb is not focusable and can't be used with a keyboard, it should use any of that. If it's supposed to be a mouse-only feature, then it should be just a div without an ARIA role. Also, arrow navigation is pointless.

See also previous comment on the nested Cover Image PR #5452 (comment) where I'm suggesting to add the "Select parent block" button to the real block toolbar.

/Cc @jasmussen @jorgefilipecosta

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant