Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select zoom out section with keyboard #63680

Closed
2 tasks done
jeryj opened this issue Jul 17, 2024 · 1 comment
Closed
2 tasks done

Can't select zoom out section with keyboard #63680

jeryj opened this issue Jul 17, 2024 · 1 comment
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented Jul 17, 2024

Description

Entering into zoom out mode clears the block selection and places it on the root wrapper. Keyboard users don't have a way to access a section to show the zoom out tools or inserters.

Proposed fix:

  • When entering into zoom out mode, don't select the root wrapping element. Instead:
  • If no block is selected, select the first section
  • If there is a block selection, select the parent section of the current block selection to keep the context close by

Step-by-step reproduction instructions

  • Open the main inserter
  • Tab to the Patterns tab
  • Press Enter
  • Tab to a pattern category
  • Press enter to go into zoom out mode
  • Tab past the category panel until you see a blue outline around the entire canvas
  • There is no way to access an individual section to show the zoom out toolbar
  • If you have access to a mouse, click a section to see the zoom out toolbar and selection outline

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@jeryj jeryj added [Type] Bug An existing feature does not function as intended [Feature] Zoom Out labels Jul 17, 2024
@jeryj jeryj self-assigned this Jul 17, 2024
@jeryj jeryj removed their assignment Jul 17, 2024
@draganescu
Copy link
Contributor

This does not appear to be an issue since the focus now remains on the toggle and zoom out is not triggered by the pattern inserter anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
Development

No branches or pull requests

2 participants