Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Shadow Range controls are unlabeled #63899

Closed
2 tasks done
afercia opened this issue Jul 24, 2024 · 3 comments · Fixed by #63908
Closed
2 tasks done

The Shadow Range controls are unlabeled #63899

afercia opened this issue Jul 24, 2024 · 3 comments · Fixed by #63908
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 24, 2024

Description

Discovered while testing #63874

All the range controls in the Shadows popover are unlabeled. Screenshot:

Screenshot 2024-07-24 at 13 59 45

Step-by-step reproduction instructions

  • Go to the Site editor > Styles > Shadows
  • Edit one of the shadows.
  • Inspect the source and observe all the 4 sliders are unlabeled: X Position, Y Position, Blur, Spread.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Package] Edit Site /packages/edit-site labels Jul 24, 2024
@afercia
Copy link
Contributor Author

afercia commented Jul 24, 2024

Introduced in #60706

Additionally:

  • The visible text: X Position, Y Position, Blur, Spread., are H2 headings. It would be best to use real, visible, label elements.
  • Teh popover title is a H5 heading, which doesn't make sense in the headings hierarchy.

@afercia
Copy link
Contributor Author

afercia commented Jul 24, 2024

Noting that the design is inconsistent, as the toggle to switch the control to the input to enter a custom value is always placed after the control in the editor. Instead, in this case it's placed after the title of the control, which is less than ideal.

Example of other controls:

Screenshot 2024-07-24 at 14 36 42

The best way to solve this issue is by changing the design, which would also make it consistent with other controls.

@afercia afercia added the Needs Design Feedback Needs general design feedback. label Jul 24, 2024
@afercia afercia self-assigned this Jul 24, 2024
@afercia
Copy link
Contributor Author

afercia commented Jul 24, 2024

As far as I can tell, this is the only Popover that has a visible title. It's a H5 heading, which is an arbitrary level in the headings hierarchy. Most popovers don't have a visible title, e.g. the Color picker in the screenshot below. Sometimes they do have an aria-label but don't have an ARIA role so that's incorrect anyways.
To fix the design and semantics inconsistency my preference would be to render a visible title for all popovers and reference it with aria-labelledby to label the popover. Lastly, the popover should be a non-modal dialog. I'll split this into a separate issue.

Screenshot 2024-07-24 at 16 57 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant