Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern shuffle: The shuffle button is displayed when there is only a single pattern in a category #63902

Closed
2 tasks done
ndiego opened this issue Jul 24, 2024 · 2 comments
Closed
2 tasks done
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@ndiego
Copy link
Member

ndiego commented Jul 24, 2024

Description

The pattern shuffle button allows users to cycle through patterns in the same category. However, if there is only a single pattern in a category (admittedly this might be a rare occurrence), the shuffle button is still displayed. When clicked, there are no additional patterns to cycle through, so the button does nothing. This happens in both Zoom out mode and at the block level.

Step-by-step reproduction instructions

  1. Create a new pattern category
  2. Add a pattern to this category
  3. Insert the pattern and see that the shuffle button is displayed, but it doesn't do anything

Screenshots, screen recording, code snippet

shuffle-single.mp4

Environment info

  • WordPress 6.6
  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@ndiego ndiego added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 24, 2024
@t-hamano
Copy link
Contributor

This issue seems to have been resolved in #63093. Does this issue still occur in Gutenberg trunk?

@ndiego
Copy link
Member Author

ndiego commented Jul 24, 2024

This issue seems to have been resolved in #63093. Does this issue still occur in Gutenberg trunk?

Ahh shoot, I had an old build. I can confirm it's not in trunk and the issue is fixed in 6.6.1. Closing this out.

@ndiego ndiego closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants