Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render empty column blocks in the editor when viewing mobile and stacked #63933

Open
richtabor opened this issue Jul 25, 2024 · 0 comments · May be fixed by #63962
Open

Do not render empty column blocks in the editor when viewing mobile and stacked #63933

richtabor opened this issue Jul 25, 2024 · 0 comments · May be fixed by #63962
Assignees
Labels
[Block] Columns Affects the Columns Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

richtabor commented Jul 25, 2024

I propose that an empty columns block should not render when columns are set to stack on mobile. On the front-end these do not take up space, nor distort the layout. Completing this would mean the front-end and editor instances are the same, meeting expectations.

One note is that the empty column should be visible when the parent Columns block is selected. This way you can put something in the empty column, but it's not always distorting layout.

Editor, desktop:

CleanShot 2024-07-25 at 07 39 27

Editor, mobile (bug visually distorting layout):

CleanShot 2024-07-25 at 07 39 39

Frontend, mobile (no empty column taking up space):

CleanShot 2024-07-25 at 07 40 22

@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Block] Columns Affects the Columns Block labels Jul 25, 2024
@richtabor richtabor added this to Polish Jul 25, 2024
@richtabor richtabor moved this to Needs development in Polish Jul 25, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 25, 2024
@richtabor richtabor moved this from Needs development to Needs review in Polish Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Status: Needs review
Development

Successfully merging a pull request may close this issue.

1 participant