Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages: clicking on page settings before patterns appear causes stacking modals #63947

Open
annezazu opened this issue Jul 25, 2024 · 1 comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Using 6.6.1 and GB 18.8.0, I noticed that when creating a new page I can select items in the sidebar as the patterns modal is loading, causing stacked modals:

parent.page.modal.mov

To replicate:

  1. Create a new page.
  2. Before the starter patterns appear, select something from the sidebar, like the parent page option.
  3. Notice that modals are stacked on top of each other.

In my mind, we just need to change the order so the sidebar options are hidden behind the starter pattern modal. Note that there's anhttps://github.com//pull/61489 around adding zoom out mode with patterns opened in the Inserter instead of starter patterns too which will help here. For now though, this would be helpful to iterate on as is.

@annezazu annezazu added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended labels Jul 25, 2024
@stokesman
Copy link
Contributor

stokesman commented Sep 9, 2024

The bug reported here is just a specific instance of #55894

I think what this usefully highlights is why the "Choose a pattern" modal can feel so interruptive and unexpected—its lag. If it could appear before (or at least very nearly at the same time as) the rest of the editor it would be so much less annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants