Update version of the framer-motion package #64003
Closed
+41
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
the
[Type] Bug
2 tasks
|
Size Change: +1.08 kB (+0.06%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
reviewed
Aug 6, 2024
| @@ -7,7 +7,7 @@ exports[`DotTip should render correctly 1`] = ` | |||
| data-wp-c16t="true" | |||
| data-wp-component="Popover" | |||
| role="dialog" | |||
| style="position: absolute; top: 0px; left: 0px; opacity: 1; transform: translateX(0px) translateY(0px) translateX(0em) scale(1) translateZ(0); transform-origin: 0% 50% 0;" | |||
| style="position: absolute; top: 0px; left: 0px; opacity: 1; will-change: auto; transform: translateX(0px) translateY(0px) translateX(0em) scale(1); transform-origin: 0% 50% 0;" | |||
There was a problem hiding this comment.
Are you able to explain why this line needed to change? I guess it's related to the e2e test failures?
There was a problem hiding this comment.
yes, exactly, seems like the new version of the package is adding this little CSS change so the snapshot tests need to be updated.
There was a problem hiding this comment.
I think it's pretty benign as changes go. It will change and there's no movement on the Z access.
I've just merged in trunk to see if that resolves the other E2E failures or futher snapshop updates are needed
# Conflicts: # packages/components/CHANGELOG.md
|
#64002 has been closed as it is no longer reproducible. Let's close this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update version of the framer-motion package to the latest version released.
Why?
There's a problem building the project using the latest typescript version and the previous framer-motion package version.
It seems to be a problem with the latest Typescript version added a few days ago in #63012.
I think that updating framer-motion package fixes the problem.
Reference of an issue that's apparently related: motiondivision/motion#2602
Fixes: #64002
How?
Updating framer-motion package version
Testing Instructions
Probably running unit tests and e2e tests should be enough.
I'm not aware if we should test this change in any other way.