Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: Re-arrange Dimensions controls #64286

Open
noisysocks opened this issue Aug 6, 2024 · 2 comments
Open

Grid: Re-arrange Dimensions controls #64286

noisysocks opened this issue Aug 6, 2024 · 2 comments
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@noisysocks
Copy link
Member

noisysocks commented Aug 6, 2024

Feedback from @richtabor:

I think we need to rethink the column start/span input controls. I expect the positioning of a block to be higher priority than how much space it is contained to. It’s also not clear what “Column” and “Row” are here (though I think it’s “start”, I’m not confident most will). Maybe they should be side by side Column Start/End (rather than start and span), and then Row Start/End.

image

Let's explore changing the Dimensions controls from:

Column span, Row span, Column, Row

To:

Column start, Row start, Column end, Row end

@noisysocks noisysocks added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Layout Layout block support, its UI controls, and style output. labels Aug 6, 2024
@vipul0425
Copy link
Contributor

Hi @noisysocks @richtabor , this change would be beneficial as it aligns directly with the CSS terms in the settings. However, I would like to understand more about the implementation of the span. Currently, we are using the input type as number, handling only numerical values. When we switch to using column start, row start, etc., how will we allow users to input values like "span 2", "span 3", or just "2", "3"? Should we simply provide a normal text input control and validate the string, or are there other options for this?

@noisysocks
Copy link
Member Author

My read is that if we switch from Column span and Row span to Column end and Row end then you'd input the column/row that you want the block to end at. You wouldn't be able to set span 2, though you could continue to use the resize handles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

2 participants