Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: sort asc/desc in view config should be hidden if no field is sortable #64816

Closed
oandregal opened this issue Aug 27, 2024 · 0 comments · Fixed by #64817
Closed

DataViews: sort asc/desc in view config should be hidden if no field is sortable #64816

oandregal opened this issue Aug 27, 2024 · 0 comments · Fixed by #64817
Assignees
@oandregal
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

oandregal commented Aug 27, 2024 •
edited
Loading

Description

When no field is sortable, the view config should hide the control to sort by ascending/descending order, like it does to sort by field.

Step-by-step reproduction instructions

  • Open the storybook for dataviews in dev mode (npm run storybook:dev).
  • Modify all the fields and set enableSorting to false.
  • Reload the storybook.

Screenshots, screen recording, code snippet

What I expected was that the asc/desc control was hidden but it's not:

Captura de ecrã 2024-08-27, às 10 13 39
@oandregal oandregal added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews labels Aug 27, 2024
@oandregal oandregal mentioned this issue Aug 27, 2024
Merged
@oandregal oandregal self-assigned this Aug 27, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 27, 2024
@oandregal oandregal mentioned this issue Aug 27, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oandregal oandregal

Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataViews: hide sort direction control if there is no sortable fields WordPress/gutenberg
1 participant
@oandregal