Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align template part edit flows? #65096

Closed
jameskoster opened this issue Sep 5, 2024 · 4 comments
Closed

Align template part edit flows? #65096

jameskoster opened this issue Sep 5, 2024 · 4 comments
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Currently the experience around editing template parts differs based on whether you're editing a page or a template.

Page editing

When editing a page, template parts can be selected but not edited until you click 'Edit' in the block toolbar, or double-click:

page.mp4

Template editing

When editing a template it's possible to select and directly manipulate blocks inside template parts:

template.mp4

I'm not sure that the differences are warranted, and would lean towards aligning around the page editing experience.

cc @WordPress/gutenberg-design

@fabiankaegy
Copy link
Member

My vote would be to revert the decision to have template parts be selectable in the "template-locked" editing mode. That should also resolve this

@noisysocks
Copy link
Member

noisysocks commented Sep 6, 2024

To me the page editor and template editor are aimed at different groups. The former is primarily for users building their website and the latter is primarily for theme authors. If anything I'd like to see even further distinction between these two editors. For example the page editor could be based around inserting patterns / zoomed out mode.

@jameskoster jameskoster changed the title Align template part edit flows Align template part edit flows? Sep 6, 2024
@jameskoster
Copy link
Contributor Author

My vote would be to revert the decision to have template parts be selectable in the "template-locked" editing mode

This would make quickly editing the header / footer more convoluted which feels like a pretty big usability trade-off to me.

To me the page editor and template editor are aimed at different groups.

That is a good observation, but I think there are a few templates that feel more like virtual pages, and likely fit the mental model for page editing. Examples being; Blog Home, Front Page, Taxonomy archives (post category archives etc.).

Related: there is active discussion around surfacing the Homepage (when set to display latest posts) in the Pages list in #60772.

For me the benefit in aligning around the page-edit experience is two-fold:

  1. Consistency; it can be quite confusing to see the same block behave differently without any obvious reason.
  2. Clarity; A drawback to the current template-edit experience is that it's easy to confuse the template part as being part of the template, and mistakenly miss that you're editing a global item.

Zoomed-out feels useful in both contexts.

@jameskoster
Copy link
Contributor Author

Closing this as it is likely superseded by #65698.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests

3 participants