Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit the Query loop 'Reload full page' labels and descriptions #65146

Open
2 tasks done
afercia opened this issue Sep 9, 2024 · 0 comments
Open
2 tasks done

Audit the Query loop 'Reload full page' labels and descriptions #65146

afercia opened this issue Sep 9, 2024 · 0 comments
Labels
[Block] Query Loop Affects the Query Loop Block Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Sep 9, 2024

Description

Follow up to #65081

I'm not sure the changes in #65081 fully addressed the issues with clarity of this feature labels and descriptions.

Right now, when enabling the pagination without a page reload, which is done by disabling 'Reload full page', the description is:

Reload the full page—instead of just the posts list—when visitors navigate between pages.

Which appears to be the description meant for the opposite case? This specific change doesn't appear right to me. Screenshot:

Screenshot 2024-09-09 at 09 22 49

Also, in #63599 (comment) a consideration was made that WordPress should not ever make assumptions on whether a feature is 'better' than another and should not use biased wording. Still, this sentence:

Enhancement disabled because there are non-compatible blocks inside the Query block.

assumes the pagination without a page reload is an 'Enhancement', which may not be true for all users. I'd think this is biased language that WordPress should not use.

Root problem

To me, the root problem with the UI of this feature is that is 'reversed'. Full page reload is the standard pagination. It shoul dbe presented as the default. The toggle should enable pagination without page reload, and no tthe other way around.

Cc @WordPress/gutenberg-design

Step-by-step reproduction instructions

  • Add a Query loop block.
  • In the settings panel go to Advanced
  • Disable 'Reload full page'.
  • Observe the description is for the opposite case: Reload the full page—instead of just the posts list—when visitors navigate between pages.
  • Add the Post content block inside the Query loop Post template.
  • A modal dialog appears to inform pagination without page reload is now disabled. Screenshot:

Screenshot 2024-09-09 at 09 39 56

  • Observe the wording in the modal dialog is still biased e.g.:
    • Currently, avoiding full page reloads is not possible ...
    • If you still want to prevent full page reloads ...
  • Close the modal dialog.
  • Select the Query loop block and observe the Advanced section in the block inspector.
  • Observe the toggle is disabled and the description wording is biased: Enhancement disabled .... Screenshot:

Screenshot 2024-09-09 at 09 40 48

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Block] Query Loop Affects the Query Loop Block labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant