Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DocumentBar with post type label #65167

Closed
3 tasks done
richtabor opened this issue Sep 9, 2024 · 7 comments · Fixed by #65170
Closed
3 tasks done

Update DocumentBar with post type label #65167

richtabor opened this issue Sep 9, 2024 · 7 comments · Fixed by #65170
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Sep 9, 2024

In an effort to improve the reference points between post types in the Site Editor, I propose removing the icons and using a visible label for the post types in the DocumentBar.

Tasks

  • Remove the icon.
  • Add support for the post type label.
  • If there's a post type label, place a · between them.

Current

current

Proposed

proposed
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Sep 9, 2024
@Mamaduka
Copy link
Member

Mamaduka commented Sep 9, 2024

Related #62186. cc @afercia

@creativecoder
Copy link
Contributor

@richtabor Note that there's one case with template parts, where the icon is used to identify the template part area (header, footer, or general), in addition to the post type. Do you think it's worth keeping the icon in this case?

Template part names are up to the theme, so these won't necessarily be named "Header" or "Footer":

image image

@creativecoder creativecoder self-assigned this Sep 9, 2024
@richtabor
Copy link
Member Author

Do you think it's worth keeping the icon in this case?

I think it's fine just to use "Template Part".

CleanShot 2024-09-09 at 16 19 24

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Sep 9, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 9, 2024
@creativecoder
Copy link
Contributor

PR here, trying this out: #65170

@creativecoder
Copy link
Contributor

I noticed that we use the same treatment with the purple color, icon, and document name in the sidebar:

image

Perhaps the title text there should also have the icon removed, to be consistent?

@jasmussen
Copy link
Contributor

You'll need to update the color of the template text to #6d6d6d, but otherwise, let's do it, it seems much clearer.

@jasmussen jasmussen added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Sep 10, 2024
@afercia
Copy link
Contributor

afercia commented Sep 10, 2024

Related #62186. cc @afercia

Thanks for the ping. I'm in favor of reducing proliferation of icons in the editor and, as @Mamaduka pointed out, this would also solve #62186

Specifically to the Document Bar

It should be entirely reconsidered. Currently, its labeling completely mismatches its functionality.

Some history:

The need to clearly identify what is being edited in the editor isn't new. On April 2017 (more than 7 years ago) in #503 the accessibility feedback was to use a visible H1 heading as first title in the <main> content. All we got is a visually hidden heading.

Years later, the design wanted to add a visible indication of the object being edited thus validating the need for a visible indication. The Document Bar was added but its implementation is less than ideal. I will try to split all this in a separate issue.

For now, I support the removal of the icon in favor of visible text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants