-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DocumentBar with post type label #65167
Comments
@richtabor Note that there's one case with template parts, where the icon is used to identify the template part area (header, footer, or general), in addition to the post type. Do you think it's worth keeping the icon in this case? Template part names are up to the theme, so these won't necessarily be named "Header" or "Footer": |
PR here, trying this out: #65170 |
You'll need to update the color of the template text to #6d6d6d, but otherwise, let's do it, it seems much clearer. |
Thanks for the ping. I'm in favor of reducing proliferation of icons in the editor and, as @Mamaduka pointed out, this would also solve #62186 Specifically to the Document Bar It should be entirely reconsidered. Currently, its labeling completely mismatches its functionality. Some history: The need to clearly identify what is being edited in the editor isn't new. On April 2017 (more than 7 years ago) in #503 the accessibility feedback was to use a visible H1 heading as first title in the Years later, the design wanted to add a visible indication of the object being edited thus validating the need for a visible indication. The Document Bar was added but its implementation is less than ideal. I will try to split all this in a separate issue. For now, I support the removal of the icon in favor of visible text. |
In an effort to improve the reference points between post types in the Site Editor, I propose removing the icons and using a visible label for the post types in the DocumentBar.
Tasks
·
between them.Current
Proposed
The text was updated successfully, but these errors were encountered: