Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Set featured image" button border flashes on focus #65299

Closed
mirka opened this issue Sep 12, 2024 · 3 comments · Fixed by #66092
Closed

"Set featured image" button border flashes on focus #65299

mirka opened this issue Sep 12, 2024 · 3 comments · Fixed by #66092
Labels
[Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@mirka
Copy link
Member

mirka commented Sep 12, 2024

Steps to reproduce

In a post, go to the Post tab in the sidebar and move the keyboard focus onto the "Set featured image" button.

Expected behavior

The focus ring shows like the other components.

Actual behavior

There is a lag between the focus ring appearing and the normal border disappearing.

Video

CleanShot.2024-09-13.at.05.11.47.mp4
@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Sep 12, 2024
@t-hamano
Copy link
Contributor

My guess is that this issue is related to #66007, because the "Set featured image" variation button also has an inset box shadow applied by default.

@Vrishabhsk
Copy link
Contributor

Hi @mirka 👋

Let me know your thoughts on this. Thanks. cc: @tyxla

@mirka mirka linked a pull request Oct 14, 2024 that will close this issue
@tyxla
Copy link
Member

tyxla commented Oct 16, 2024

Thanks for working to resolve the "Set featured image" issue @Vrishabhsk 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants