Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move To tool - replace with something better #65459

Open
talldan opened this issue Sep 18, 2024 · 2 comments
Open

Move To tool - replace with something better #65459

talldan opened this issue Sep 18, 2024 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@talldan
Copy link
Contributor

talldan commented Sep 18, 2024

It was mentioned in #65204 that the PR plans to remove/replace Select Mode. This presents an issue for the 'Move To' tool which leverages select mode. That's why, in that PR, the Move To is also being removed.

For some background, the Move To tool is useful for keyboard users, as it's possibly the only way a block can be moved into a nested context using only the keyboard.

The Move to tool has also faced criticism over being too confusing - it's not clear which keys to use to perform a particular move, and often folks go to use it and consider it broken.

I think there's a good opportunity now to come up with something better and simpler. Let's discuss!

@talldan talldan added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 18, 2024
@talldan
Copy link
Contributor Author

talldan commented Sep 18, 2024

I had a look at how Notion manages this. It uses Cmd/Ctrl + Shift + Up or Down arrows to move a block (but this is usually 'make a selection to the end'). When doing so the block moves through nesting levels at the same time as moving up or down. Also the block moves immediately, whereas Move To moves a blue line and then user has to press enter to commit the move.

I think moving immediately is a much better idea (simpler to understand with better feedback). I also like the idea of moving through nested levels, but it might be a poor default for WordPress as there can be a lot of levels. 🤔

@draganescu
Copy link
Contributor

draganescu commented Sep 18, 2024

I too think that moving with keyboard shortcuts (which we already have but without moving up / down the tree, just for reordering siblings) is the best way forward particularly because it moves the content not some abstract representation. (also soo #65204 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants