Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentOnly Select Mode: In Top Toolbar mode, it is not possible to toggle between Design and Edit modes #65508

Closed
2 tasks done
andrewserong opened this issue Sep 20, 2024 · 2 comments · Fixed by #65511
Closed
2 tasks done

ContentOnly Select Mode: In Top Toolbar mode, it is not possible to toggle between Design and Edit modes #65508

andrewserong opened this issue Sep 20, 2024 · 2 comments · Fixed by #65511
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@andrewserong
Copy link
Contributor

Description

Following #65204:

After switching to the Edit mode (ContentOnly / Select Mode), if a user sets the editor to the top toolbar mode, the toggle for editing modes disappears, and it isn't possible to switch back to the other mode, unless you disable the top toolbar mode.

Should the toggle for Edit vs Design modes persist even when the toolbar is set to display at the top?

Step-by-step reproduction instructions

  1. Open the site editor
  2. Click the pointer icon at the top left and toggle to the edit mode
  3. In the settings at the top right of the editor, switch to the top toolbar mode
  4. Notice that you can no longer switch editing modes at the top left

Screenshots, screen recording, code snippet

2024-09-20.15.35.52.mp4

Environment info

  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@andrewserong andrewserong added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Sep 20, 2024
@vipul0425 vipul0425 mentioned this issue Sep 20, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 20, 2024
@vipul0425
Copy link
Contributor

Hi @andrewserong, I have raised PR for this issue. Let me know if anything needs to be updated.

Thanks 🙇

@andrewserong
Copy link
Contributor Author

Thanks for the quick fix on this one @vipul0425, nice work! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Makes edit mode selector persistent in top toolbar mode. vipul0425/gutenberg
2 participants
@andrewserong @vipul0425