Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-selected blocks + contentOnly representations: always show text styles if range includes text #65645

Open
jasmussen opened this issue Sep 25, 2024 · 3 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Sep 25, 2024

If you select two paragraphs, you get text formatting tools across, in the inspector:

two text blocks

If you select two image blocks, you get image formatting tools across, in the inspector:

two images

If you select mixed content, such as a paragraph and an image, you get no controls at all, in the inspector:

paragraph and image

This is not very useful.

Proposed solution

If you have a mixed selection that includes text, always show the text formatting tools.

paragraph-and-image-with-formatting-tools

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Sep 25, 2024
@jasmussen jasmussen moved this to Needs Dev in Design priorities Sep 25, 2024
@jasmussen jasmussen added the Needs Dev Ready for, and needs developer efforts label Sep 25, 2024
@Mamaduka
Copy link
Member

IIRC, this is intentional. The inspector controls are only displayed when blocks of the same type are selected since they share attribute definitions.

Side note: Multi-editing blocks have their issues when specific changes might get lost. See #51609 and #41260.

@jasmussen
Copy link
Contributor Author

Yes, it definitely feels intentional so I'm not suggesting this as a bug, or even an urgent one, can be 6.8. But mainly, it feels like whenever you have text blocks as part of your selection, surfacing text-block attributes across is worth it. Kind of like how you might select across text and images in a Google Doc and change press ⌘B, you'd at least make the text bold even if not the image. So it's a writing flow suggestion with lowish priority.

@jasmussen jasmussen added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Sep 25, 2024
@jasmussen jasmussen changed the title Multi-selecting blocks, always show text styles if range includes text Multi-selected blocks + contentOnly representations: always show text styles if range includes text Nov 13, 2024
@jasmussen
Copy link
Contributor Author

Updated this issue to include that these tools should also be shown in contentOnly representations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs Dev
Development

No branches or pull requests

2 participants