Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thick, blurry, block outlines while zoomed out #65744

Closed
richtabor opened this issue Sep 30, 2024 · 6 comments
Closed

Thick, blurry, block outlines while zoomed out #65744

richtabor opened this issue Sep 30, 2024 · 6 comments
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

richtabor commented Sep 30, 2024

The outline styles on block hover and selection are thicker than they should be when zoomed out, blurry even. This will become more prominent as each section's blocks can be edited in zoom out—as seen in #65702 (comment).

CleanShot 2024-09-30 at 09 45 27

I expect these outlines to be the same style as when not zoomed out.

@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Feature] Zoom Out labels Sep 30, 2024
@ndiego ndiego moved this to 📥 Todo in WordPress 6.7 Editor Tasks Sep 30, 2024
@getdave
Copy link
Contributor

getdave commented Oct 1, 2024

This will need backporting to 6.7. Thanks for adding to the board 👍

@youknowriad
Copy link
Contributor

Looking at the code, it seems the outline width is rendered within the iframe which means it's impacted by the zoom-scaling. So by default it would appear thinner and to account for that scale, we scale it back using CSS which produces the blurry effect I guess.

@youknowriad
Copy link
Contributor

So not easy solution here :)

Two potential solutions:

  • Accept that the outline is thinner/scaled down when zoomed out.
  • Try a "JS based outline": Do not apply the zoom-out within the iframe and instead use a BlockPopover similar to what we do for the block toolbar to render the outline outside of the iframe. (Might be subject to small glitches if the block changes size when it's actually selected...)

@richtabor
Copy link
Member Author

richtabor commented Oct 4, 2024

Did something change recently? It's looking a bit better.

CleanShot.2024-10-04.at.14.09.32.mp4

@getdave
Copy link
Contributor

getdave commented Oct 7, 2024

I'm not aware of any PRs directly targeting this specific bug. However, if it's improved then I'd be more than happy to see this closed out. I think this can be your call @richtabor 🙇

@richtabor
Copy link
Member Author

I'm cool with closing for now. It's ok as-is.

@richtabor richtabor closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.7 Editor Tasks Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

No branches or pull requests

3 participants