Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only render the zoom out inserter after the selected block, not before #65756

Closed
richtabor opened this issue Sep 30, 2024 · 5 comments
Closed
Assignees
Labels
[Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

richtabor commented Sep 30, 2024

To help reduce conflicts as seen below, let's only render the inserter after the selected block when zoomed out:

CleanShot.2024-09-30.at.12.37.55.mp4

Note that this may not be necessary, if #65754 is completed and feels alright. The scenario above would not be possible, as the inserter would only render on block selection.

@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Feature] Zoom Out labels Sep 30, 2024
@richtabor richtabor changed the title Only render the zoom out inserter after the current block, not before Only render the zoom out inserter after the selected block, not before Sep 30, 2024
@jeryj
Copy link
Contributor

jeryj commented Sep 30, 2024

Rather than only do the bottom one, I’d also support only showing them on block selection or an extended hover at an allowed insertion area (like in the normal block canvas). If we only do the bottom one, we won’t be able to insert a pattern before the first section.

@richtabor
Copy link
Member Author

I’d also support only showing them on block selection or an extended hover at an allowed insertion area (like in the normal block canvas).

Yea, that should be the first attempt before not showing the before one. #65754

@getdave
Copy link
Contributor

getdave commented Oct 1, 2024

This will need backporting to 6.7. I'll add to the board.

@jeryj
Copy link
Contributor

jeryj commented Oct 1, 2024

@richtabor Should this be closed because #65759 to only show inserters when a block is selected?

@richtabor
Copy link
Member Author

@richtabor Should this be closed because #65759 to only show inserters when a block is selected?

Sure, I think #65759 worked out well.

@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.7 Editor Tasks Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

No branches or pull requests

3 participants