Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inset Blue Focus Ring on Vertical Tabs #65863

Closed
2 tasks done
jeryj opened this issue Oct 3, 2024 · 4 comments · Fixed by #65387
Closed
2 tasks done

Inset Blue Focus Ring on Vertical Tabs #65863

jeryj opened this issue Oct 3, 2024 · 4 comments · Fixed by #65387
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented Oct 3, 2024

Description

The vertical tabs have a regression in their focus styles where it is inset from the highlighted indicator.

Step-by-step reproduction instructions

  • Go to the Preferences Pane
  • Go to the tabs
  • Use the arrow keys to move between the tabs
  • Blue focus ring is inset from the gray indicator

Screenshots, screen recording, code snippet

Patterns Category Tabs
Inserter pattern tab with inset focus ring

Preferences Tabs
Image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@jeryj jeryj added the [Type] Bug An existing feature does not function as intended label Oct 3, 2024
@jeryj
Copy link
Contributor Author

jeryj commented Oct 3, 2024

@ciampo @DaniGuardiola @t-hamano - Pinging because it looks like y'all have been working hard on the animation improvement from #64926 :)

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 3, 2024
@DaniGuardiola
Copy link
Contributor

Those screenshots are from an older version of Tabs. If you try the latest trunk you'll see the changes that I think fit what you're after in this issue, let me know :)

@DaniGuardiola
Copy link
Contributor

Ah, wait, I think the PR that was supposed to take care of this failed to merge due to test errors. Let me take a look. In any case, the associated PR should be closed, though appreciate the effort!

@jeryj
Copy link
Contributor Author

jeryj commented Oct 3, 2024

I tested out #65387 and it looks like it fixes this well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
2 participants