Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to shared block - Cancel - Admin Message #6597

Closed
StaggerLeee opened this issue May 4, 2018 · 6 comments
Closed

Convert to shared block - Cancel - Admin Message #6597

StaggerLeee opened this issue May 4, 2018 · 6 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Milestone
WordPress 5.x

Comments

@StaggerLeee
Copy link

StaggerLeee commented May 4, 2018 •
edited
Loading

Think it is a bug.

  • Start procedure to convert any block to shared.
  • Cancel procedure, do not proceed with converting.
  • Admin message "Block created" appears at the top.

What is created ?
@karmatosed
Copy link
Member

It looks like it's create a block without a title. See here:

2018-05-10 at 20 09

I totally agree it should be not doing that. You cancelled therefore it should just not make a block. Thanks for reporting this.

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label May 10, 2018
@mtias mtias added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Jun 22, 2018
@noisysocks noisysocks self-assigned this Jul 23, 2018
@ZebulanStanphill
Copy link
Member

This is still happening in Gutenberg 3.6.2 and master.

@noisysocks
Copy link
Member

Yes, it's not been worked on. I'll remove myself as the assignee in case it encourages someone else to pick this up. Otherwise, it is on my list and I will eventually get to it 🙂

@noisysocks noisysocks removed their assignment Aug 24, 2018
@ZebulanStanphill
Copy link
Member

Should this be put in the WordPress 5.0 milestone?

@karmatosed
Copy link
Member

@ZebulanStanphill I think we can probably put this in before, let's milestone for next release and take from there.

@karmatosed karmatosed added this to the 3.7 milestone Aug 25, 2018
@youknowriad youknowriad modified the milestones: 3.7, 3.8 Aug 30, 2018
@mtias mtias added this to the Future: 5.1 milestone Nov 12, 2018
@mtias mtias added the Needs Testing Needs further testing to be confirmed. label Nov 12, 2018
@youknowriad
Copy link
Contributor

Closing as there's no "cancel" button anymore.

@snyk-bot snyk-bot mentioned this issue Apr 25, 2023
Open
@npneeraj npneeraj mentioned this issue Apr 25, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this issue Apr 25, 2023
Open
@soloinovator soloinovator mentioned this issue Apr 25, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this issue Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
WordPress 5.x
Development

No branches or pull requests
6 participants
@karmatosed @youknowriad @mtias @noisysocks @StaggerLeee @ZebulanStanphill