Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockCanvas doesn't respect the height property anymore. #65976

Closed
2 tasks done
youknowriad opened this issue Oct 9, 2024 · 1 comment · Fixed by #65977
Closed
2 tasks done

BlockCanvas doesn't respect the height property anymore. #65976

youknowriad opened this issue Oct 9, 2024 · 1 comment · Fixed by #65977
Assignees
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Description

When building third-party block editors, you can set the height of the block canvas using the height prop in theory. (See https://wordpress.org/gutenberg-framework/docs/intro)

That said, this doesn't seem to work anymore

There are also other related issues:

  • Now there's a border for the iframe of the block canvas
  • The width of the block canvas is not 100%

Step-by-step reproduction instructions

Create a custom a block editor using the instructions in https://wordpress.org/gutenberg-framework/docs/intro and notice the height is not respected.

Alternatively, you can just use the "box" playground in the Storybook and change the "height" prop and see that it doesn't change anything.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Framework Issues related to broader framework topics, especially as it relates to javascript labels Oct 9, 2024
@youknowriad youknowriad self-assigned this Oct 9, 2024
@youknowriad
Copy link
Contributor Author

I think this PR was responsible for some of this breakage #61424 maybe not all of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant