Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Block: Background wrapper for 'Button Inside' option #69375

Open
2 of 6 tasks
Rishit30G opened this issue Mar 1, 2025 · 1 comment
Open
2 of 6 tasks

Search Block: Background wrapper for 'Button Inside' option #69375

Rishit30G opened this issue Mar 1, 2025 · 1 comment
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Enhancement A suggestion for improvement.

Comments

@Rishit30G
Copy link
Contributor

Description

This issue is a follow up of #69318

Currently, the ‘Button Inside’ option in the Search Block is missing a background wrapper with a common color as of the input, making the input and button appear separate instead of part of a single container.

Step-by-step reproduction instructions

  1. Add a new post
  2. Add a new search block
  3. From the BlockToolbar option select the 'Change Button Position'
  4. Select the 'Button inside' option from the dropdown
  5. Notice that only a border around the button and the input appear

Screenshots, screen recording, code snippet

Notice that the even though the border surrounds the button and the input, but as per the 'Button Inside', there is absence of a background wrapper which should cover the button and the input together with a background color as that of the input.

Image

Environment info

  • Gutenberg 20.4.0-rc
  • WordPress 6.7.2

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@Rishit30G Rishit30G added the [Type] Bug An existing feature does not function as intended label Mar 1, 2025
@Rishit30G
Copy link
Contributor Author

Rishit30G commented Mar 1, 2025

This is the redesigned version, which I believe is much more appropriate:

Image

Any thoughts on this would be appreciated before I proceed with implementation. 👍🏻

@carolinan carolinan added [Type] Enhancement A suggestion for improvement. [Block] Search Affects the Search Block - used to display a search field and removed [Type] Bug An existing feature does not function as intended labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants