Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor spacing for NoticeActions in Notice component #69426

Open
3 of 6 tasks
daledupreez opened this issue Mar 5, 2025 · 0 comments · May be fixed by #69430
Open
3 of 6 tasks

Poor spacing for NoticeActions in Notice component #69426

daledupreez opened this issue Mar 5, 2025 · 0 comments · May be fixed by #69430
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@daledupreez
Copy link

Description

The spacing between the main children of the Notice component and actions added to the Notice component via the noticeActions prop is too tight. Also, there is no vertical spacing between multiple notice actions, which is very noticeable on mobile.

Note that there should be space between the text and the actions as per the Notice layout in the WordPress Design System Figma here. The Figma doesn't capture a mobile viewport, but the buttons being so close together is a bad layout regardless.

Step-by-step reproduction instructions

These reproductions rely on Storybook as a way to exclude other CSS as much as possible.

Basic spacing between children and actions

Vertical spacing between actions on mobile

Screenshots, screen recording, code snippet

Spacing when actions are present

Image

Spacing when actions are vertical

Image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@daledupreez daledupreez added the [Type] Bug An existing feature does not function as intended label Mar 5, 2025
@Mamaduka Mamaduka added the [Feature] UI Components Impacts or related to the UI component system label Mar 5, 2025
@Infinite-Null Infinite-Null linked a pull request Mar 5, 2025 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 5, 2025
@t-hamano t-hamano added the [Package] Components /packages/components label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants