Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9.2] Convert to Blocks not properly converting successive Shortcodes #7030

Closed
GlennMartin1 opened this issue May 30, 2018 · 3 comments · Fixed by #7846
Closed

[2.9.2] Convert to Blocks not properly converting successive Shortcodes #7030

GlennMartin1 opened this issue May 30, 2018 · 3 comments · Fixed by #7846
Assignees
Labels
[Feature] Paste [Feature] Shortcodes Related to shortcode functionality [Type] Bug An existing feature does not function as intended
Milestone

Comments

@GlennMartin1
Copy link

GlennMartin1 commented May 30, 2018

Describe the bug
On a Classic block with multiple successive Shortcodes, choose the option "Convert to Blocks." Not all the Shortcodes will convert.

To Reproduce
Steps to reproduce the behavior:

  1. create a new page/post
  2. add this content in a Classic block
    [shortcodetest]
    [shortcodetest]
    [shortcodetest]
  3. choose "Convert to Blocks"
  4. BUG: It will not create all the Shortcode blocks

Different combinations of text with successive Shortcodes result in different behavior, but in most/all scenarios, at least one of multiple successive Shortcodes does not convert.

Expected behavior
Any combination of Shortcodes, even in succession, should convert to Shortcode blocks.

@danielbachhuber danielbachhuber self-assigned this Jun 4, 2018
@danielbachhuber danielbachhuber added the [Type] Bug An existing feature does not function as intended label Jun 6, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Jun 6, 2018
@danielbachhuber
Copy link
Member

I've confirmed this bug:

convertmulti

In my testing, it's the last shortcode that isn't converted to a block.

@danielbachhuber
Copy link
Member

I suspect this is going to be a more common issue than not, so elevating priority.

Related #3900 #4456

@danielbachhuber
Copy link
Member

Interestingly, opening a post in the Classic Editor immediately wraps shortcodes with paragraph tags:

image

image

Related #3900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Paste [Feature] Shortcodes Related to shortcode functionality [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants