Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block inserter not appearing above Classic Block #7917

Closed
maddisondesigns opened this issue Jul 12, 2018 · 7 comments
Closed

Block inserter not appearing above Classic Block #7917

maddisondesigns opened this issue Jul 12, 2018 · 7 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@maddisondesigns
Copy link

Describe the bug
After inserting a Classic Block I can't insert a block above it as the Block inserter doesn't appear.

gutenberg_cantinsertblockbeforeclassicblock

To Reproduce
Steps to reproduce the behavior:

  1. Create new page
  2. Insert paragraph block with content
  3. Insert Classic Block with content
  4. Try to insert Block above Classic Block

Expected behavior
Block inserter should appear above all blocks

macOS Sierra 10.12.1
Firefox Quantum 61.0.1 (64-bit)
Gutenberg 3.2.0

@aduth aduth added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Jul 12, 2018
@designsimply
Copy link
Member

Tested and confirmed that I cannot see any block inserter for the classic block.

Video: 42s
Seen at http://alittletestblog.com/wp-admin/post.php?post=13963&action=edit running WordPress 4.9.7 and Gutenberg 3.2.0 using Firefox 61.0.1 on macOS 10.13.5.

@maddisondesigns
Copy link
Author

They also won't randomly show up on other blocks as well. Just had an issue where the block inserter wouldn't appear on a Paragraph block that was sitting between an image and another Paragraph block.

@ZebulanStanphill
Copy link
Member

I think this is a duplicate of #7884.

@maddisondesigns
Copy link
Author

@SuperGeniusZeb Nope, because the inserter doesn't appear on Blocks with Toolbars either. It's not just an issue on Blocks without Toolbars

@ZebulanStanphill
Copy link
Member

@maddisondesigns Is that not exactly what #7884 is about? The sibling inserter currently never appears above the currently selected block (because it was assumed that the toolbar would usually get in the way, except that some blocks do not have toolbars or in the case of the Classic block do not have the same kind of toolbar).

@maddisondesigns
Copy link
Author

@SuperGeniusZeb All #7884 seems to talk about is that it it doesn't appear on blocks without toolbars. That's not the case. It also doesn't appear on Classic Blocks (which does have a toolbar) and also (as mentioned in one of my other comments), it sometimes doesn't appear on other blocks as well, such as the Paragraph Block. They seem like two different issues to me.

@designsimply designsimply added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jul 18, 2018
@designsimply
Copy link
Member

I tested again and found that the inserter does appear above classic blocks if they are not selected:

screen shot 2018-07-17 at tue jul 17 7 31 16 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=13999&action=edit running WordPress 4.9.7 and Gutenberg 3.2.0 using Firefox 61.0.1 on macOS 10.13.5.

Closing as a duplicate because the inserter does sometimes appear for the classic block, because this issue now has a bit of extra noise in it 🙂 compared to the other issue, and because I think @SuperGeniusZeb is correct that the fix for #7884 will likely address the issue raised here. If it doesn't, we can re-open this one after #7884 is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants