Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in Gallery captions are low-contrast #7952

Closed
kjellr opened this issue Jul 13, 2018 · 2 comments
Closed

Links in Gallery captions are low-contrast #7952

kjellr opened this issue Jul 13, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Milestone
3.6

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 13, 2018

Describe the bug
Our default blue link color for text inside of gallery captions make them barely readable against the dark gradient background.

To Reproduce
Steps to reproduce the behavior:

  1. Create a gallery.
  2. Add a caption to an image in the gallery.
  3. Add a link inside that caption.

Screenshots

screen shot 2018-07-13 at 9 22 18 am

Suggestion

Perhaps we continue using white text there, and only add the underline to links:

screen shot 2018-07-13 at 9 26 36 am
@nfmohit nfmohit mentioned this issue Jul 17, 2018
Merged
4 tasks
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jul 18, 2018
@mtias mtias added this to the 3.4 milestone Jul 19, 2018
@pento pento modified the milestones: 3.4, 3.5 Jul 30, 2018
@kjellr kjellr mentioned this issue Jul 30, 2018
Closed
12 tasks
@nfmohit
Copy link
Member

nfmohit commented Aug 7, 2018

#8004 applies the proposed changes.

@gziolo gziolo modified the milestones: 3.5, 3.6 Aug 8, 2018
@tofumatt
Copy link
Member

Fixed in #8004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
3.6
Development

No branches or pull requests
7 participants
@tofumatt @pento @mtias @gziolo @designsimply @kjellr @nfmohit