Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent "Reset" controls in the block settings sidebar. #8179

Closed
kjellr opened this issue Jul 24, 2018 · 2 comments
Closed

Inconsistent "Reset" controls in the block settings sidebar. #8179

kjellr opened this issue Jul 24, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 24, 2018

The text size and color controls in the block sidebar have buttons/links to "reset" to the default settings, but their treatment and labels are inconsistent. You can see this most evidently in the Paragraph block sidebar:

screen shot 2018-07-24 at 2 34 24 pm

I'd suggest we change all to use text links, and go with "Reset", since that seems like a clear label for both. I'd also suggest that these links don't need to appear if settings haven't been changed yet.

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Jul 24, 2018
@kjellr kjellr changed the title Inconsistent "Reset" controls the block settings sidebar. Inconsistent "Reset" controls in the block settings sidebar. Jul 24, 2018
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Jul 25, 2018

I'd also suggest that these links don't need to appear if settings haven't been changed yet.

Alternatively, the buttons could be visible, but disabled when there is nothing to reset.

@mtias
Copy link
Member

mtias commented Jul 13, 2021

Tracking in #27331.

@mtias mtias closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants