Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner: Nothing is displayed #8566

Closed
mmtr opened this issue Aug 5, 2018 · 1 comment
Closed

Spinner: Nothing is displayed #8566

mmtr opened this issue Aug 5, 2018 · 1 comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@mmtr
Copy link
Contributor

mmtr commented Aug 5, 2018

Describe the bug
When rendering a Spinner component outside Gutenberg, nothing is displayed. Actually, a div with the spinner and is-active classes is rendered, but these classes are not giving any style at all.

To Reproduce
Execute the code below in a new React project after installing @wordpress/components.

import React from 'react';
import ReactDOM from 'react-dom';
import { Spinner } from '@wordpress/components';

import '@wordpress/components/build-style/styles.css';

const MySpinner = () => (
	<Spinner />
);

ReactDOM.render(
	<MySpinner />,
	document.getElementById( 'root' )
);

Expected behavior
A spinner should appear.

Desktop:

  • OS: macOS High Sierra
  • Browser: Chrome
  • Version: 67

Additional context
Issue found while working on #8338 and Automattic/wp-calypso#26367

@youknowriad
Copy link
Contributor

I think we should do the same we did for the button component: Avoid relying on WordPress Core Styles for the spinner component and copy those styles to Gutenberg itself.

@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants