Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dirty detection #916

Closed
aduth opened this issue May 26, 2017 · 2 comments
Closed

Improve dirty detection #916

aduth opened this issue May 26, 2017 · 2 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Enhancement A suggestion for improvement.

Comments

@aduth
Copy link
Member

aduth commented May 26, 2017

Updated: While the original issue below has since been resolved, we should investigate cases where changes may be unintentionally reflected in a new post. For #1059, I suspect it was because the list block was setting attributes immediately upon becoming mounted, causing the editor to consider itself dirty. We should look to make dirty detection more durable.


Original issue:

Steps to reproduce:

  1. Visit Gutenberg page

Expected result: There are no changes indicated.

Actual result:

New post with changes

@aduth aduth added General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended labels May 26, 2017
@nylen
Copy link
Member

nylen commented May 26, 2017

It's a bit disheartening to see this happening already, even though we are taking a very simple approach to dirty detection. Some related discussion on other issues/PRs:

Also, I'm not really sure how to debug this, due to the extremely annoying #919.

@aduth
Copy link
Member Author

aduth commented Jun 7, 2017

The original steps are now resolved as of #1059, but I'm going to keep this open and rename the issue, as I'd like to consider how we might make dirty detection more durable.

@aduth aduth changed the title Changes indicated on new post Improve dirty detection Jun 7, 2017
@aduth aduth added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Enhancement A suggestion for improvement. and removed General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended labels Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants