Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label prop in ColorPalette does not display #9216

Closed
mikelinden1 opened this issue Aug 21, 2018 · 4 comments
Closed

Label prop in ColorPalette does not display #9216

mikelinden1 opened this issue Aug 21, 2018 · 4 comments
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience

Comments

@mikelinden1
Copy link

mikelinden1 commented Aug 21, 2018

Describe the bug
When using the <ColorPalette /> component, the label prop doesn't display.

To Reproduce

<ColorPalette
    label={__('Background Color')}
    value={backgroundColor}
    onChange={(val) => setAttributes({ backgroundColor: val })}
/>

Expected behavior
Display a "Background Color" label.

@designsimply designsimply added [Feature] Extensibility The ability to extend blocks or the editing experience Needs Technical Feedback Needs testing from a developer perspective. labels Aug 21, 2018
@DannyCooper
Copy link
Contributor

DannyCooper commented Aug 22, 2018

<ColorPalette> doesn't support a label prop:

<ColorPalette 
	colors={ colors } 
	value={ color }
	onChange={ ( color ) => setState( { color } ) } 
/>

@mikelinden1
Copy link
Author

Ah that makes sense - I was looking at the source for the ColorPaletteControl wondering why it accepted a label and showed the selected color but neither worked lol. Sorry to bother.

@designsimply designsimply removed the Needs Technical Feedback Needs testing from a developer perspective. label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience
Projects
None yet
Development

No branches or pull requests

4 participants