Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard trap when using Firefox and Shift+Tab on some blocks #977

Closed
afercia opened this issue Jun 1, 2017 · 2 comments
Closed

Keyboard trap when using Firefox and Shift+Tab on some blocks #977

afercia opened this issue Jun 1, 2017 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jun 1, 2017

Looks like tabbing backwards when using Firefox breaks on some editor blocks. Seems to me it happens just for some block types, not sure if this is already a known issue.

To reproduce, just tab through the blocks and controls till the block that in the content sample content is after the split one ("... like this one, which is separate from the above and right aligned.") then tab backwards.
If the trap doesn't happen the first time, tab again forwards and backwards.

To make it simpler to understand, I've made a video using a very strong focus style:

https://cloudup.com/ckt5HyHe5K7

In the last part of the video, I'm just keeping Shift+Tab pressed and as you can see, as soon as the previous block toolbar appears, focus is moved back to the following block again, in an endless tab sequence loop.
I can't reproduce in Chrome.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended labels Jun 1, 2017
@afercia
Copy link
Contributor Author

afercia commented Jul 12, 2017

I can't reproduce the keyboard trap in Firefox any longer.

However, I still see a different behavior between Chrome and Firefox.

  • Chrome: tabbing backwards, it is possible to go through all the blocks and all their toolbars controls
  • Firefox: tabbing backwards, on many blocks just the block gets focused and there's no way to go through the blocks toolbars controls

@afercia
Copy link
Contributor Author

afercia commented Aug 1, 2017

Although tabbing through blocks and focusing them is still inconsistent across browsers and block types, I can't reproduce the keyboard trap on current master. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

1 participant