media_view_strings filter execution order not consistent with classic editor

[iandunn]

When adding images to a Gallery block, the button on the final step has an empty string inside it, instead of Insert into Post.

To Reproduce

1. Add a Gallery block
2. Click on Media Library button
3. Click on the Media Library tab (if not already selected)
4. Select multiple images
5. Click on Create a new gallery button

Screenshots

Desktop (please complete the following information):

• OS X 10.13.6
• Firefox 63
• Gutenberg 3.8.0

[Soean]

I can't reproduce this issue on 3.8

[iandunn]

Ah, you're right, it's a plugin conflict. I should have checked that first.

https://github.com/Codeinwp/themeisle-companion/blob/3ef1a45/obfx_modules/mystock-import/init.php#L239

What they're doing works in Classic, though, so it may still be a back-compat issue. The problem seems to be that, in the Classic editor, the media_view_strings filter is called before admin_enqueue_scripts is fired by admin-header.php; but in Gutenberg it's the opposite.

cc @abaicus, @selul as an FYI

[danielbachhuber]

What they're doing works in Classic, though, so it may still be a back-compat issue. The problem seems to be that, in the Classic editor, the media_view_strings filter is called before admin_enqueue_scripts is fired by admin-header.php; but in Gutenberg it's the opposite.

Related #4929

[antpb]

@johnbillion is this still valid after #10660 ?

I noticed you added the 5.0 milestone and then a few days after, the above PR was merged. I think the changes made will solve this. Want to verify.

[johnbillion]

I added it as it's closely related to #4929 which was in the 5.0 milestone. It does indeed look like this was fixed in #10660. Closing off.