Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable Blocks: "Export as JSON" link does not work in Firefox #9919

Closed
designsimply opened this issue Sep 14, 2018 · 3 comments · Fixed by #10000
Closed

Reusable Blocks: "Export as JSON" link does not work in Firefox #9919

designsimply opened this issue Sep 14, 2018 · 3 comments · Fixed by #10000
Assignees
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Milestone

Comments

@designsimply
Copy link
Member

Steps to reproduce:

  1. Install Gutenberg 3.9.0-rc.1.
  2. Open Firefox and to to your site's WP Admin.
  3. Go to Posts > Add New.
  4. Add a reusable block so at least one exists (otherwise I don't see a way to reach the Blocks page at wp-admin/edit.php?post_type=wp_block).
  5. Click the block inserter (+).
  6. Click the gear icon at the bottom right of the Reusable panel in the block library.
  7. Hover over any block in the list and click the "Export as JSON" link that appears.

Result: the "Export as JSON" link seems to generate a JSON file via an API call (I can see it in the Network tab) but does not result in a downloaded file when using Firefox 62.0 on macOS 10.13.6.

screen shot 2018-09-14 at 11 34 41 am
Seen at https://madefortesting.com/wp-admin/edit.php?post_type=wp_block running WordPress 4.9.8 and Gutenberg 3.9.0-rc.1 using Firefox 62.0 on macOS 10.13.6.

Question: what are the intended steps to import a reusable block JSON file on a site which does not yet have any reusable blocks?

Aside: this is what I see when I click on the title of a reusable block on the Blocks page at wp-admin/edit.php?post_type=wp_block. Is this the expected view? Should the title and content of a reusable block be editable here? Should I be able to change post status, visibility, and publication date/time for reusable blocks?

screen shot 2018-09-14 at 11 27 39 am
Seen at https://madefortesting.com/wp-admin/post.php?post=538&action=edit running WordPress 4.9.8 and Gutenberg 3.9.0-rc.1 using Firefox 62.0 on macOS 10.13.6.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Sep 14, 2018
@tofumatt tofumatt added this to the 3.9 milestone Sep 14, 2018
@tofumatt tofumatt changed the title [3.9.0-rc.1] Reusable Blocks: "Export as JSON" link does not work in Firefox Reusable Blocks: "Export as JSON" link does not work in Firefox Sep 14, 2018
@tofumatt
Copy link
Member

I know this process is all new, so there's no guideline 😄

Any issues with a release candidate should be added to the (still open) 3.9 milestone. I added this one, but it's better to add them there than but it in the title. Any RC bug/regression is likely high priority though, feel free to use that label 😄

@designsimply
Copy link
Member Author

Noting that the question about the single-item editing experience was opened as a separate issue at #9964.

@furyuri
Copy link

furyuri commented Sep 3, 2019

I'm having trouble getting export as JSON to work at all on localhost/XAMPP - I keep getting this error in the console:
Chrome:
index.js?ver=1567441560:1 Uncaught (in promise) {code: "invalid_json", message: "The response is not a valid JSON response."}
Firefox:
Unhandled promise rejection Object { code: "invalid_json", message: "The response is not a valid JSON response." }
(tried in Chrome and Firefox)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants