-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance reliability of how Site Health enqueued assets module detects assets #135
Comments
@aristath Anything to add? Do you think this is already good to open a PR for addressing your comment, or should we evaluate the technical approach a bit more before writing code? cc @manuelRod |
Assigning this one to myself so I can take a look again on Monday. |
Hello, @aristath @felixarntz I was working already on the proposed enhances, I didn't realise you have merged the previous PR :D Anyways, here is the new PR with a few of the things addressed, we can keep the conversation going on there! |
@manuelRod Oh, sorry about that - I guess I merged that a bit too quickly. But that's great, will review soon! |
@aristath can you review this PR too? |
Fixed via #136 |
The initial implementation for the Site Health enqueued assets module (see #25) is a solid start, but there's room for enhancement in how reliably it detects enqueued assets. This was already pointed out in the initial PR review, but it was decided to merge the large first PR first and then implement this enhancement separately, to allow for a more focused review.
This issue is primarily to address the following review comment: #54 (comment)
There are potentially more aspects we can improve around this, let's explore this here.
The text was updated successfully, but these errors were encountered: