Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up code owners #23

Closed
tillkruss opened this issue Nov 29, 2021 · 3 comments · Fixed by #56 or #91
Closed

Set up code owners #23

tillkruss opened this issue Nov 29, 2021 · 3 comments · Fixed by #56 or #91
Assignees
Labels
Infrastructure Issues for the overall performance plugin infrastructure

Comments

@tillkruss
Copy link
Member

As per @felixarntz suggestion in #2, should we set up a CODEOWNERS file to automatically assign issues and PRs?

It would help reduce the noise.

@tillkruss tillkruss added Infrastructure Issues for the overall performance plugin infrastructure Needs Decision labels Nov 29, 2021
@JustinyAhin
Copy link
Member

@tillkruss it would definitely make sense to set up that to automatically assign PR reviewers. Not sure why/if we should do the same for issues though.

@JustinyAhin
Copy link
Member

And from the GitHub documentation you shared, it is only for PRs.

@felixarntz
Copy link
Member

felixarntz commented Jan 14, 2022

I just realized that the current CODEOWNERS file is not fully accurate:

  • It still contains modules/webp-uploads but following Module Slugs Naming Proposal #46 all modules will be in focus area-specific directories, so this needs to be changed to modules/images - which actually makes the CODEOWNERS file maintenance a lot simpler in the long run.
  • Based on the above, I suggest we now already add the code owners for all 5 focus areas, even if there's no code yet. We couldn't do this in the way it currently is since we don't know in advance which modules will exist, but we do already know the focus areas, so we can add the focus POCs as code owners, for modules/images, modules/javascript, modules/site-health, modules/measurement, and modules/object-caching.

I suggest we open a follow-up PR for this issue to fix/expand this.

cc @JustinyAhin @tillkruss

@felixarntz felixarntz reopened this Jan 14, 2022
@felixarntz felixarntz added Needs Dev Anything that requires development (e.g. a pull request) and removed Needs Decision labels Jan 14, 2022
@eclarke1 eclarke1 added Needs Review and removed Needs Dev Anything that requires development (e.g. a pull request) labels Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure
Projects
None yet
4 participants