-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings page #27
Comments
Completed the proposed specification in here. |
What about simply "Settings->Performance", adding module doesn't make much sense for users and can be restrictive? One requirement which was previously raised is the ability for hosts/developer to bypass the screen and preset modules activation. |
Sounds good! I've put "Performance Modules" as the full title for now, but in the menu it is just "Performance". Does that make sense?
I suggest we do that in a follow-up issue/PR to keep things simple to review. Doing that should be straightforward (e.g. we introduce a filter to control active modules and then only register the settings screen if that filter is not in use). The PR #30 is ready for review. |
Yes
SG |
The plugin should provide a simple UI (filterable) to enable/disable modules broken down by focus area.
Requirements
PERFLAB_MODULES_SCREEN
constant) should be implemented, with a dynamic list of all modules and a checkbox to toggle each one on/off.Focus
definition (see Define basic module specification #2).PERFLAB_MODULES_SETTING
.Specification Details
modules
directory and gathers all available module information from each module'sload.php
file header. This can largely be copied from the WordPress core functionget_plugins()
which includes all necessary parsing logic.manage_options
viaadd_options_page()
.images
,javascript
,site-health
,measurement
, andobject-caching
, as well as a genericother
section.enabled
sub-setting, associated with the settings section specified in the module'sFocus
header field.PERFLAB_MODULES_SETTING
option.This issue depends on #2 for finalizing the module specification and on #28 for completing the PHPUnit infrastructure necessary to validate that the changes included here work correctly.
The text was updated successfully, but these errors were encountered: