Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional documentation for each module #50

Closed
adamsilverstein opened this issue Dec 15, 2021 · 3 comments
Closed

Add additional documentation for each module #50

adamsilverstein opened this issue Dec 15, 2021 · 3 comments
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Documentation Documentation to be added or enhanced

Comments

@adamsilverstein
Copy link
Member

Each module should include some basic documentation (both user facing and developer oriented) about what it does and how to use it.

  • Add a README.md in each module's folder root. Primarily for developers who would be browsing the repository.
  • Display a long description alongside the module in the settings screen. Primarily for users who are using the plugin.
@adamsilverstein adamsilverstein added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure labels Dec 15, 2021
@adamsilverstein
Copy link
Member Author

Question: for the long description part, do we want to use the existing Description field (

* Description: Enhances performance for something.
) or add a new field to the header?

@felixarntz
Copy link
Member

@adamsilverstein I think sticking to a brief description in the Description field would be more in line with how plugins handle this.

Regarding the longer description, I think that's a great idea, but I'm not sure a module header would be suitable for that. What if for example we want multiple sections or any formatting such as bold/italic text etc? Maybe we need another approach here.

I think what would be a neat approach here would be even if we could make the contents of the README.md for each module actually available in the plugin's settings screen - almost like the readme for wordpress.org plugins can also be viewed in the WordPress Plugins screen. For example:

  • Show a little "i" info icon next to each module in the settings screen.
  • Clicking that would open a modal.
  • The modal would show the full readme content from README.md - it would basically need to parse that markdown into HTML, which shouldn't be too much of a stretch using a library.

The above would allow us to show as flexible information in the plugin we could possibly need, and even more importantly it would allow us to keep maintenance low - a single README.md file would serve for both people looking at the repo and people using the plugin.

If we wanted to include contributor-/developer-specific information in the README.md files, we could even define a special heading (e.g. ## Development or ## Contributing), and then everything after that could be cut off and not be displayed within the plugin.

What do you think?

@swissspidy
Copy link
Member

Now that we split modules into standalone plugins, I don't think this applies anymore. Each plugin has a thorough readme already, and for contributing we have dedicated docs too.

@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Development

No branches or pull requests

3 participants