Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp available focus areas #554

Closed
felixarntz opened this issue Oct 11, 2022 · 5 comments · Fixed by #566
Closed

Revamp available focus areas #554

felixarntz opened this issue Oct 11, 2022 · 5 comments · Fixed by #566
Assignees
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Documentation Documentation to be added or enhanced
Milestone

Comments

@felixarntz
Copy link
Member

In the performance chat on October 11, a few proposals for aligning our focus areas were discussed, based on some requests and how the current focus areas have been working.

  1. Introduce a "Database" focus area?
  2. Introduce a "CSS" focus area or expand the "JavaScript" focus to become "Assets" / "CSS & JS"?
  3. Remove the "Site Health" focus area and instead relocate those checks to their relevant topic focus area?

Let's vote on these items here, and once decisions have been made, we can follow up on focus leads. Eventually, a PR should be opened against this issue to make the relevant changes to the plugin codebase (e.g. update CODEOWNERS and perflab_get_focus_areas() function, as well as potentially migrate modules).

@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure Needs Decision labels Oct 11, 2022
@mxbclang
Copy link
Contributor

mxbclang commented Oct 11, 2022

For proposal 1, please vote on this comment with a 👍 or 👎 emoji to introduce a new Database focus area. Voting will close on Tuesday, October 18, 2022 at 5pm UTC.

@mxbclang
Copy link
Contributor

For proposal 2, please vote on this comment with:

  • 😄 to introduce a new CSS focus area
  • 🎉 to expand the JavaScript focus area to include CSS and rename it to "CSS & JS" or "Assets"
  • ❤️ to keep things as is and not add a new CSS focus area nor add it to the JS focus area

Voting will close on Tuesday, October 18, 2022 at 5pm UTC.

@mxbclang
Copy link
Contributor

mxbclang commented Oct 11, 2022

For proposal 3, please vote on this comment with a 👍 or 👎 emoji to remove the Site Health focus area and relocate existing Site Health modules to the relevant topic focus area. Voting will close on Tuesday, October 18, 2022 at 5pm UTC.

@mxbclang
Copy link
Contributor

Voting is now closed.

For proposal 1, based on 10 thumbs up votes, we will introduce a new Database focus area.

For proposal 2, based on 7 🎉 votes and 1 😄 votes, we will expand the JavaScript focus area to include CSS and rename it to "CSS & JS" or "Assets".

For proposal 3, based on 7 👍 votes and 1 👎 vote, we will remove the Site Health focus area and relocate existing Site Health modules to the relevant topic focus area.

@felixarntz and I will work on making the appropriate changes related to these results and update the team in our October 25 performance chat.

Thanks to everyone for voting! Closing this issue.

@mxbclang mxbclang mentioned this issue Oct 18, 2022
3 tasks
@felixarntz
Copy link
Member Author

@bethanylang I would suggest we reopen this to have it as an overview for any PRs that address this. We also still need to follow up on asking for focus leads.

I think what we need in terms of code changes are:

  • PR that updates focus areas in CODEOWNERS (see Focus area updates #564)
  • PR that updates focus areas in the codebase (to do)
    • Update perflab_get_focus_areas() to return the latest focus areas
    • Rename javascript focus area accordingly, including the directory in modules
    • Move site-health modules into their new focus area directories
    • Implement logic in perflab_get_module_settings() to migrate all old ("legacy") module slugs to the new ones (e.g. if you have site-health/audit-autoloaded-options in the DB, it should become database/audit-autoloaded-options)

We will also need to create/rename the GitHub focus area labels accordingly. Regarding the Site Health focus area label, let's keep it (for the history), but just rename it to something like "[LEGACY] [Focus] Site Health" or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Documentation Documentation to be added or enhanced
Projects
None yet
3 participants