-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the Enable WebP Uploads?
module if server does not support it.
#65
Comments
@mitogh This would tie into the infrastructure aspect of the overall plugin, and I'm not sure we should disable the entire module in that screen. We could instead show e.g. an admin notice triggered by the module itself if the server doesn't support WebP? If we decide this should be shown before the module is even active, we would need to define a centralized approach so that a module is able to declare / run certain "requirements" logic even when it is not active - so depending on what we decide here this either becomes a |
Thanks @felixarntz The main idea is basically to provide feedback to the user in order to allow a user to identify that a module is not active or can't be active because server limitations, instead of allowing users to enable the module even when no real action can happen. |
Additionally, would be ideal if we say that the |
That part should be implicitly covered, since the overall plugin will require 5.8.0 as its minimum WP version (we'll always require the latest WordPress versions since the changes target core, so we'll need to build against the latest version for most modules anyway). |
I'm going to close this issue due to the conversation above. Furthermore, while the module is called "WebP Uploads", what it introduces beyond that is a new infrastructure to have multiple MIME type versions available for an uploaded image, which is not only about WebP. I think the checks we have to not attempt to generate WebP files when the server doesn't support it is sufficient. |
Right now there's no information when adding the plugin if my current server supports
WebP
or not instead of allowing users to enable the module. Instead, disable the module or don't render the module when is not supported, instead, a message can be displayed instead that the module was not activated dueWebP
is not supported on the current server where the images are being tested.The text was updated successfully, but these errors were encountered: