PHP: Support $env and $cwd proc_open arguments #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the following
proc_open
arguments:$env_vars
and$cwd
.proc_open signature is:
With this PR, it may we called as follows:
And the spawn handler will be called as follows:
Implementation
The
proc_open
C handler now passes the information from these arguments to thejs_proc_open
handler, which then propagates them to the spawn handler.Testing instructions
Confirm the unit tests pass