Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The props bot sometimes adds repetitive comments rather than updating the existing comment #54

Closed
andrewserong opened this issue Feb 5, 2024 · 1 comment · Fixed by #59
Assignees
Labels
[Type] Bug Report Something isn't working

Comments

@andrewserong
Copy link
Contributor

Description

In a particular Gutenberg PR, the props bot appears to be adding repetitive comments after each commit or comment, rather than checking and updating the existing comment.

For example: WordPress/gutenberg#57841 (comment) — note that alternating comments / commits appear to be between a comment or commit by a user, and then a new comment from the props bot.

Is it possible that the props bot is unable to find its existing comment to update, for some reason?

Another idea from @tellthemachines: could this be to do with this PR originating from before the props bot was added?

Version

trunk

Workflow file

https://github.com/WordPress/gutenberg/blob/trunk/.github/workflows/props-bot.yml

Link

WordPress/gutenberg#57841

@desrosj
Copy link
Contributor

desrosj commented Feb 5, 2024

I think that this is due to the upper limit being 100 when querying the REST API to look for a previous comment.

Looking at the action, this will need to be a different solution than #53 because those queries utilize the GraphQL API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants