Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove All specific alignment CSS from block based themes and replace them with layout confings #234

Open
youknowriad opened this issue Mar 18, 2021 · 0 comments
Open

Remove All specific alignment CSS from block based themes and replace them with layout confings #234

youknowriad opened this issue Mar 18, 2021 · 0 comments

Comments

@youknowriad
Copy link
Contributor

youknowriad commented Mar 18, 2021 •
edited
Loading

Now that this PR WordPress/gutenberg#29335 landed on Gutenberg. Any theme with an experimental-theme.json will be impacted.

Here are the changes that need to be made for these themes If they do support "wide/full" alignments:

  • Remove the old theme support flag.
  • Remove all alignments CSS from your theme's CSS files.
  • Define the default "layout" config in theme.json (this is going to be used as a default layout style for the post editor). and update the FSE templates to inherit the default layout where necessary.

Follow #233 as an example of how to do that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@youknowriad