Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Variation: Pilgrimage #134

Closed
luminuu opened this issue Aug 30, 2022 · 5 comments · Fixed by #166
Closed

Variation: Pilgrimage #134

luminuu opened this issue Aug 30, 2022 · 5 comments · Fixed by #166

Comments

@luminuu
Copy link
Member

luminuu commented Aug 30, 2022

grafik

grafik

grafik

Figma: https://www.figma.com/file/0NcNCYScCtXrgbUQ6Z6fAf/TT3%3A-Pilgrimage

@critterverse
Copy link
Collaborator

This style variation has been selected to be bundled with the Twenty Twenty-Three default theme! @beafialho and I have made some tweaks to the submission as a part of the curation process to ensure that all the selected variations work together nicely as a collection. Here are the requested changes:

Pilgrimage

  • Let’s try the bright green neon colors for some of the text such as post titles to make this variation even more vibrant
  • Same note as above for separator lines
  • Could we add a bright colored duotone effect to images if overlay functionality doesn't ship in time for 6.1?
  • We also thought this variation would be super cool with a subtle background gradient that incorporates a CSS pattern (like the one previously proposed in Gutenberg issue #38577) to showcase how much the background can be customized.

No explicit next steps are needed — feel free to update theme.json files where relevant or they will be updated in development. Thanks for the contribution!

@kathryncodes
Copy link
Contributor

Hi @mikachan, I'd love to take a stab at updating the theme.json files! This would be my first open source contribution, so I just wanted to know if there's anything specific I should know before jumping in?

@mikachan
Copy link
Member

@kathryncodes, awesome! There's a getting started guide in the readme which should help you get your environment set up. Gutenberg also has a great guide for working with Git, including forking a repository and creating a pull request.

Just let us know if you need any help!

@luminuu
Copy link
Member Author

luminuu commented Sep 13, 2022

I just saw that the PR for adding gradients to the Post Featured Image block has been merged: WordPress/gutenberg#43838

Can we explore adding my original idea of using gradients on the featured images, or do we have to stick to the proposed changes by @critterverse?

@critterverse
Copy link
Collaborator

Can we explore adding my original idea of using gradients on the featured images, or do we have to stick to the proposed changes by @critterverse?

Definitely! Excited to see that one get merged 🎉

It would be great if we could keep some of the other edits that were suggested (type colors, separator color, and background pattern) but that sounds great to go with the overlay functionality instead of the duotone.

@mikachan mikachan linked a pull request Sep 17, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants