Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Remove opinionated settings from block markup #84

Closed
3 tasks done
mikachan opened this issue Aug 19, 2022 · 4 comments
Closed
3 tasks done

Remove opinionated settings from block markup #84

mikachan opened this issue Aug 19, 2022 · 4 comments
Labels
Good First Issue Good for newcomers [Type] Enhancement New feature or request

Comments

@mikachan
Copy link
Member

mikachan commented Aug 19, 2022

As TT3 is focused on style variations, it would be good to remove as many opinionated styles from the block markup as possible. There are a few places where this is happening, but sometimes it can be difficult where unique styles have been required. Here's an example of where we have done this previously: #31

This issue is to track where we could consider moving these settings, and encourage discussion around this for each area:

@mikachan mikachan added [Type] Enhancement New feature or request Good First Issue Good for newcomers labels Aug 19, 2022
@beafialho
Copy link
Collaborator

I agree 404 can become much smaller:

Captura de ecrã 2022-08-22, às 09 53 33

About Search and Home, I'm not sure. What changes do you think could be done to make it less opinionated?

@pbking
Copy link
Collaborator

pbking commented Aug 22, 2022

I don't see that the xx-large size has been used anywhere yet. Would it make sense to use that value, but maybe crank it up a bit? I'm actually keen to keep the value on the 404 page (font-size:clamp(4rem, 40vw, 20rem) or something close to it) for xx-large (which feels like "the upper end of sizes we should create").

@pbking
Copy link
Collaborator

pbking commented Aug 23, 2022

I didn't notice any opinion in the search template that we might want to relocate (other than some spacing bits that are already being addressed in #52

@mikachan
Copy link
Member Author

mikachan commented Sep 2, 2022

I'm going to close this, as I think we've currently removed as much opinion as possible from the templates. Please open another issue if you spot anything similar.

@mikachan mikachan closed this as completed Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue Good for newcomers [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants